-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove enzyme #2724
Merged
Merged
Remove enzyme #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icon has been mocked because we test here AppIcon and not Icon. Last test `renders provided fallbackIcon on img error` has been deleted because it is very close to `renders provided fallbackIcon when fetch error occurs` and it was testing internals which we do not test with react-testing-library
I added onChange attribute to avoid test failing because "Warning: Failed prop type: You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultValue`. Otherwise, set either `onChange` or `readOnly`."
I kept the snapshot here because it works well like this and it would take time to refactor for little benefits.
Almost 100% rewritten because we are testing internals (and for a good reason here because it has no UI) and it is very different to test internal in enzyme and react-testing-library.
It is just a single snapshot that has no really purpose.
Passing props to the input is not a react-testing-library kind of tests.
zatteo
force-pushed
the
feat/remove-enzyme
branch
from
December 6, 2024 09:19
b59bc54
to
93323a8
Compare
zatteo
force-pushed
the
feat/remove-enzyme
branch
from
December 6, 2024 10:02
93323a8
to
30ac215
Compare
BundleMonFiles updated (1)
Unchanged files (2)
Total files change -27B -0.07% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
commented
Dec 6, 2024
JF-Cozy
approved these changes
Dec 9, 2024
Bravo pour la PR 👏 |
🎉 This PR is included in version 113.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.